Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logfile size upload limit to the reportportal plugin #3199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add logfile size upload limit to the reportportal plugin #3199

wants to merge 2 commits into from

Conversation

kkaarreell
Copy link
Collaborator

@kkaarreell kkaarreell commented Sep 9, 2024 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • modify the json schema
  • include a release note

@kkaarreell kkaarreell self-assigned this Sep 9, 2024
@kkaarreell kkaarreell mentioned this pull request Sep 9, 2024
Open
@kkaarreell kkaarreell marked this pull request as draft September 9, 2024 09:01
@kkaarreell kkaarreell force-pushed the ks_rp_limit branch 2 times, most recently from b9a19af to a81dc30 Compare September 9, 2024 09:14
@happz
Copy link
Collaborator

happz commented Sep 9, 2024

Would it be useful to submit at least an abridged version of the log, with the "too long, had to cut" header? With the proposed code, user gets a note and nothing more, while even a shortened log might bring at least some value.

@kkaarreell kkaarreell force-pushed the ks_rp_limit branch 3 times, most recently from 556a7d5 to 6445517 Compare September 9, 2024 15:11
@kkaarreell kkaarreell marked this pull request as ready for review September 9, 2024 15:25
@kkaarreell kkaarreell force-pushed the ks_rp_limit branch 2 times, most recently from ec94f05 to 6ec0722 Compare September 12, 2024 07:06
@happz happz added the plugin | reportportal The reportportal report plugin label Sep 24, 2024
@happz happz added this to the 1.37 milestone Sep 24, 2024
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 24, 2024
@psss psss changed the title reportportal: add logfile size upload limit Add logfile size upload limit to the reportportal plugin Sep 24, 2024
psss
psss requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Looks good, only we should also update the schema to add the newly supported option. Also, it might be worth at least a short release note?

tmt/steps/report/reportportal.py Show resolved Hide resolved
@psss psss removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 24, 2024
@happz happz self-requested a review September 30, 2024 18:02
@psss
Copy link
Collaborator

psss commented Oct 1, 2024

Missing schema update, release note, open question, moving to 1.38.

@psss psss modified the milestones: 1.37, 1.38 Oct 1, 2024
@kkaarreell kkaarreell force-pushed the ks_rp_limit branch 2 times, most recently from b84a6c3 to af55e9a Compare October 2, 2024 07:23
@kkaarreell kkaarreell force-pushed the ks_rp_limit branch 5 times, most recently from 4b3b9d8 to 5f1ba96 Compare October 16, 2024 07:22
@kkaarreell
Copy link
Collaborator Author

@psss @happz @martinhoyer Hi, I did some updates in the script so please review it whether it makes sense. I have decided to introduce separate limit for traceback log as this is the input for RP AutoAnalysis and I believe that it doesn't make sense to match 1MB logs.

@kkaarreell kkaarreell requested a review from psss October 16, 2024 07:22
@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 22, 2024
therazix
therazix reviewed Oct 24, 2024
View reviewed changes
tmt/steps/report/reportportal.py
Comment on lines +71 to +72
f"exceeds tmt reportportal plugin limit of {settings.size} bytes."
f"The limit is controlled with {option} plugin option or"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken, there will be no space between these sentences. Shouldn't it be like this?

Suggested change
f"exceeds tmt reportportal plugin limit of {settings.size} bytes."
f"The limit is controlled with {option} plugin option or"
f"exceeds tmt reportportal plugin limit of {settings.size} bytes. "
f"The limit is controlled with {option} plugin option or "

@thrix thrix modified the milestones: 1.38, 1.39 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer

@psss psss Awaiting requested review from psss psss is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@kkaarreell kkaarreell

Labels
ci | full test Pull request is ready for the full test execution plugin | reportportal The reportportal report plugin
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.
6 participants
@kkaarreell @happz @psss @martinhoyer @therazix @thrix